added sql rollbacks

[grallewellyn]

I wanted to deploy but deployments are failing to DIT and UAT with this error message

Run echo "Deploy mas.dit.maap-project.org/root/maap-api-nasa-ci/maap-project/maap-api-nasa:DIT to DIT"
Deploy mas.dit.maap-project.org/root/maap-api-nasa-ci/maap-project/maap-api-nasa:DIT to DIT
+++ dirname -- /home/ubuntu/actions-runner/_work/maap-api-nasa/maap-api-nasa/.github/workflows/deploy-on-runner.sh
++ cd -- /home/ubuntu/actions-runner/_work/maap-api-nasa/maap-api-nasa/.github/workflows
++ pwd
+ SCRIPT_DIR=/home/ubuntu/actions-runner/_work/maap-api-nasa/maap-api-nasa/.github/workflows
+ ssh -i '***' *** 'docker compose -f docker-compose-maap-api.yml down'
time="2026-06-09T23:45:48Z" level=warning msg="/home/ubuntu/docker-compose-maap-api.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion"
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

Fixes: #242

[sujen1412]

Suggestion: Add a global teardown_request hook

The per-endpoint rollbacks in this PR are good for letting individual requests fail gracefully, but they don't fully prevent dirty sessions from leaking between requests if any unpatched endpoint hits a DB error.

A global teardown_request hook in maapapp.py would act as a systemic safety net:

@app.teardown_request
def teardown_request(exception):
    if exception:
        db.session.rollback()
    db.session.remove()

db.session.remove() tears down the SQLAlchemy session at the end of every request and returns the connection to the pool — so no dirty state can carry over to the next request regardless of which endpoint caused the failure. This is what would have prevented the PendingRollbackError we saw in production today cascading across requests.

With this in place, the per-endpoint rollbacks here are still worth keeping for request-level error handling (so the current request can return a meaningful error instead of a 500), but the teardown hook covers everything else.

[sonarqubecloud]

Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[grallewellyn]

Implemented @sujen1412's suggestion and fixed the API deployment pipeline problem that was stopping us from deploying the DIT API
This is deployed on the DIT API now