Skip to content

Lep 6 postponed target assignment fix #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j-rafique merged 1 commit into from
May 12, 2026
Merged

Lep 6 postponed target assignment fix #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion x/audit/v1/keeper/audit_peer_assignment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,11 @@ func computeStorageTruthTargetsForReporter(params paramsLike, activeSorted []str
}

active := sortedUniqueStrings(activeSorted)
targetCandidates := intersectionInOrder(sortedUniqueStrings(targetsSorted), active)
// Active supernodes are the only eligible challengers, but storage-truth targets
// must include the epoch target set captured by the anchor. That target set
// intentionally includes POSTPONED supernodes so active peers can continue
// submitting clean PASS proofs needed for storage-truth recovery.
Comment thread
j-rafique marked this conversation as resolved.
targetCandidates := sortedUniqueStrings(targetsSorted)
if len(targetCandidates) == 0 {
targetCandidates = active
}
Expand Down
22 changes: 22 additions & 0 deletions x/audit/v1/keeper/audit_peer_assignment_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,28 @@ func TestStorageTruthAssignmentUsesOneThirdCoverage(t *testing.T) {
require.Len(t, assignedTargets, 2)
}

func TestStorageTruthAssignmentIncludesPostponedTargets(t *testing.T) {
params := types.DefaultParams().WithDefaults()
params.StorageTruthEnforcementMode = types.StorageTruthEnforcementMode_STORAGE_TRUTH_ENFORCEMENT_MODE_FULL
params.StorageTruthChallengeTargetDivisor = 1

active := []string{"sn-a", "sn-b"}
targets := []string{"sn-postponed"}
seed := []byte("01234567890123456789012345678901")

assigned := false
for _, reporter := range active {
reporterTargets, isProber, err := computeAuditPeerTargetsForReporter(&params, active, targets, seed, reporter)
require.NoError(t, err)
require.True(t, isProber)
if containsString(reporterTargets, "sn-postponed") {
assigned = true
}
}

require.True(t, assigned, "active challengers must be able to target postponed supernodes for storage-truth recovery")
}

func TestStorageTruthAssignmentDisabledUsesLegacyCoverage(t *testing.T) {
params := types.DefaultParams().WithDefaults()
params.StorageTruthEnforcementMode = types.StorageTruthEnforcementMode_STORAGE_TRUTH_ENFORCEMENT_MODE_UNSPECIFIED
Expand Down
Loading