Skip to content

encapsulating media engine - #71

Merged
Lori-Shu merged 1 commit into
masterfrom
dev
Aug 31, 2026
Merged

Lori-Shu merged 1 commit into
masterfrom
dev

Conversation

@Lori-Shu

Copy link
Copy Markdown
Owner

No description provided.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

This PR introduces a major architectural refactor, replacing the internal decode_engine with a new media_engine library.

Reviewed changes

  • Architectural Refactor: Removed the decode_engine module and encapsulated media handling into a new external/internal library media_engine.
  • UI Enhancements: Added frequency analysis and mel-bar visualization in body_ui.rs and presentation.rs.
  • System Integration: Updated appui.rs, controlbar_ui.rs, and whispercpp_transcriber.rs to interface with the new media_engine instead of the old decode_engine.

The refactor appears sound and aligns with the goal of encapsulating media handling. Given the critical nature of the media playback and synchronization flows now handled by media_engine, please ensure thorough testing of:

  1. Audio/Video synchronization.
  2. Seeking behavior (as seen in controlbar_ui.rs changes).
  3. Media file loading and reset_input behavior.

Pullfrog  | Fix it ➔View workflow run | Using google/gemini-3.1-flash-lite𝕏

@Lori-Shu
Lori-Shu merged commit 42aa59f into master Aug 31, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant