Conversation
There was a problem hiding this comment.
Important
This PR introduces a major architectural refactor, replacing the internal decode_engine with a new media_engine library.
Reviewed changes
- Architectural Refactor: Removed the
decode_enginemodule and encapsulated media handling into a new external/internal librarymedia_engine. - UI Enhancements: Added frequency analysis and mel-bar visualization in
body_ui.rsandpresentation.rs. - System Integration: Updated
appui.rs,controlbar_ui.rs, andwhispercpp_transcriber.rsto interface with the newmedia_engineinstead of the olddecode_engine.
The refactor appears sound and aligns with the goal of encapsulating media handling. Given the critical nature of the media playback and synchronization flows now handled by media_engine, please ensure thorough testing of:
- Audio/Video synchronization.
- Seeking behavior (as seen in
controlbar_ui.rschanges). - Media file loading and
reset_inputbehavior.
google/gemini-3.1-flash-lite | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.