Skip to content

fix: Guard install rules behind option#28

Merged
ReenigneArcher merged 1 commit into
masterfrom
fix/install
Jun 29, 2026
Merged

fix: Guard install rules behind option#28
ReenigneArcher merged 1 commit into
masterfrom
fix/install

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Add LIZARDBYTE_COMMON_INSTALL option (defaults to top-level only) to gate all install() calls and package config generation, preventing install rule conflicts when consumed as a subdirectory.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (60bf936) to head (4c4bdf0).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          213       213           
  Branches        12        12           
=========================================
  Hits           213       213           
Flag Coverage Δ
Linux-Clang 87.50% <ø> (ø)
Linux-GCC 100.00% <ø> (ø)
Linux-python 100.00% <ø> (ø)
Windows-MSVC 100.00% <ø> (ø)
Windows-MinGW-UCRT64 100.00% <ø> (ø)
Windows-python 100.00% <ø> (ø)
macOS 87.50% <ø> (ø)
macOS-python 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60bf936...4c4bdf0. Read the comment docs.

Add LIZARDBYTE_COMMON_INSTALL option (defaults to top-level only) to gate all install() calls and package config generation, preventing install rule conflicts when consumed as a subdirectory.
@ReenigneArcher ReenigneArcher merged commit 3f29834 into master Jun 29, 2026
28 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/install branch June 29, 2026 17:42
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant