fix(macOS): absolute mouse coordinate scaling#51
Merged
Conversation
Normalize absolute mouse motion on macOS to the event-provided coordinate space instead of using display scaling assumptions, with clamping to valid source bounds before mapping to display coordinates. This also clarifies public API docs for absolute and fractional coordinates, adds test hooks and unit coverage for coordinate conversion behavior, and expands runtime mouse tests to assert absolute event fields for both integer and fractional submissions.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 74.53% 74.88% +0.35%
==========================================
Files 19 19
Lines 5883 5890 +7
Branches 2245 2245
==========================================
+ Hits 4385 4411 +26
+ Misses 1307 1285 -22
- Partials 191 194 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Normalize absolute mouse motion on macOS to the event-provided coordinate space instead of using display scaling assumptions, with clamping to valid source bounds before mapping to display coordinates. This also clarifies public API docs for absolute and fractional coordinates, adds test hooks and unit coverage for coordinate conversion behavior, and expands runtime mouse tests to assert absolute event fields for both integer and fractional submissions.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.