Skip to content

ci: Harden Windows driver installer and signing gates#41

Merged
ReenigneArcher merged 1 commit into
masterfrom
ci/fix-windows-driver-install
Jul 5, 2026
Merged

ci: Harden Windows driver installer and signing gates#41
ReenigneArcher merged 1 commit into
masterfrom
ci/fix-windows-driver-install

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Update the Windows CI workflow to prevent hanging MSI operations by adding explicit 5-minute process timeouts, killing stalled msiexec processes, and printing both MSI and driver logs on failure. Restrict Azure Trusted Signing enforcement to release publish pushes, while using the local test certificate for pull requests and non-release builds so routine CI runs are not blocked.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Update the Windows CI workflow to prevent hanging MSI operations by adding explicit 5-minute process timeouts, killing stalled msiexec processes, and printing both MSI and driver logs on failure. Restrict Azure Trusted Signing enforcement to release publish pushes, while using the local test certificate for pull requests and non-release builds so routine CI runs are not blocked.
@sonarqubecloud

sonarqubecloud Bot commented Jul 5, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.77%. Comparing base (ab39ba0) to head (ec203d1).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   85.12%   89.77%   +4.65%     
==========================================
  Files          13       14       +1     
  Lines        3777     4500     +723     
  Branches     1343     1512     +169     
==========================================
+ Hits         3215     4040     +825     
- Misses        298      343      +45     
+ Partials      264      117     -147     
Flag Coverage Δ
Linux-Clang 71.09% <ø> (ø)
Linux-GCC 83.61% <ø> (ø)
Windows-MSVC 90.22% <ø> (?)
Windows-MinGW-UCRT64 82.15% <ø> (?)
macOS 70.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 11 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab39ba0...ec203d1. Read the comment docs.

@ReenigneArcher ReenigneArcher merged commit 24bf6b7 into master Jul 5, 2026
25 checks passed
@ReenigneArcher ReenigneArcher deleted the ci/fix-windows-driver-install branch July 5, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant