Conversation
added 18 commits
June 3, 2026 21:58
Add two new documentation files: 1. docs/internal/syscall-interposition.md - Technical overview of the interposition infrastructure - Explains core components and integration points - Documents API usage and debugging 2. docs/contribute/glibc-interposition-guide.md - Step-by-step guide for applying changes to different glibc versions - Practical examples and troubleshooting tips - Version-specific considerations These guides help other developers apply the syscall interposition changes to their glibc versions and understand the underlying architecture.
…pick approach Add two detailed documentation files: 1. docs/internal/syscall-interposition.md - Technical overview of the interposition infrastructure - Explains core components and integration points - Documents API usage and debugging - Emphasizes git cherry-pick as the recommended approach 2. docs/contribute/glibc-interposition-guide.md - Step-by-step guide for applying changes to different glibc versions - Detailed git cherry-pick instructions with conflict resolution - Practical examples and troubleshooting tips - Version-specific considerations - Automation script examples These guides help other developers apply the syscall interposition changes to their glibc versions using best practices (git cherry-pick) and understand the underlying architecture.
| @@ -0,0 +1,62 @@ | |||
| use libc::c_void; | |||
| @@ -0,0 +1,392 @@ | |||
|
|
|||
Member
There was a problem hiding this comment.
Why is this different from the wasm syscall tables?
| INSTANCE_NUMBER, RAWPOSIX_CAGEID, UNUSED_ARG, UNUSED_ID, WASMTIME_CAGEID, | ||
| }; | ||
| use sysdefs::constants::syscall_const::{CLONE_SYSCALL, EXEC_SYSCALL, EXIT_SYSCALL}; | ||
| use sysdefs::constants::syscall_const::{CLONE3_SYSCALL, EXEC_SYSCALL, EXIT_SYSCALL}; |
Member
There was a problem hiding this comment.
Should this be done for both wasm and MPK?
Comment on lines
+89
to
+90
| init_wasmtime(lind_manager.clone()); | ||
| init_mpk(lind_manager.clone()); |
Member
There was a problem hiding this comment.
should these be done all the time or does it makes sense to have this be configurable?
| @@ -0,0 +1,402 @@ | |||
|
|
|||
JustinCappos
left a comment
JustinCappos
left a comment
Member
There was a problem hiding this comment.
First of all, I know this is draft.
I wonder if you'd be better off submitting a PR first to generalize the interface and then adding in MPK as a "plug-in" for that interface.
I did also notice a fair amount of code that looks duplicated related to the system call processing / interfaces. Maybe there is a better abstraction for all of this?
added 2 commits
July 28, 2026 17:41
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Key changes:
All these changes are needed to support multiple other runtimes along WASM.
Related issues
none
Testing
shows same behavior under
Compatibility and security impact
Checklist
contribution guidelines.