automated: linux: add remoteproc smoke test - #634
Open
lool wants to merge 1 commit into
Open
Conversation
Some remoteprocs silently fail to come up, e.g. when their firmware can't be loaded after an initramfs update. Add a smoke test which enumerates every remoteproc and checks that it reached the running or attached state. Auto-detect all remoteprocs by default; set DEVICE to target specific ones. Some remoteprocs are not booted by the kernel at all, either because no firmware is shipped for them or because another subsystem owns their lifecycle, e.g. ath11k for wpss. Skip modem and wpss by default rather than failing them, and make the list a parameter since it varies per SoC. Their state is still logged to help triage. Boards without any remoteproc report remoteproc-device-exists as skip instead of failing. Signed-off-by: Loïc Minier <loic.minier@oss.qualcomm.com>
Contributor
Author
mwasilew
approved these changes
Aug 10, 2026
bhcopeland
reviewed
Aug 11, 2026
| local name="$1" | ||
| for dir in $(list_remoteprocs); do | ||
| [ "$(cat "${dir}/name")" = "${name}" ] && echo "${dir}" | ||
| done |
bhcopeland
reviewed
Aug 11, 2026
| # remoteprocs are booted asynchronously, so they may not be enumerated yet | ||
| wait_for_device | ||
|
|
||
| if [ -n "${DEVICE}" ]; then |
Member
There was a problem hiding this comment.
So this checks if device has remoteproc. I would use report_skip "remoteproc-device-exists" and report_pass "remoteproc-device-exists" at the top of the test.
Something like
all_dirs="$(list_remoteprocs)"
if [ -z "${all_dirs}" ]; then
report_skip "remoteproc-device-exists"
else
report_pass "remoteproc-device-exists"
fi
(and catch it at the bottom of this function). So you will get a remoteproc-device-exists skip when no remoteprocs are found
bhcopeland
reviewed
Aug 11, 2026
| local name | ||
| name="$(cat "${dir}/name")" | ||
| if [ "$(remoteprocs_by_name "${name}" | wc -l)" -gt 1 ]; then | ||
| echo "remoteproc-${name}-$(basename "${dir}")-running" |
Member
There was a problem hiding this comment.
Will the name will be stable across boots. Could we not use basename "$(readlink -f "${dir}/device")" to get a reliable name beforehand, just to be sure.
bhcopeland
reviewed
Aug 11, 2026
| # a requested remoteproc which doesn't exist is a failure, unless it is one | ||
| # which is not expected to be running anyway | ||
| dirs="" | ||
| for name in ${DEVICE}; do |
Member
There was a problem hiding this comment.
Might be worth a cheap dedupe call here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some remoteprocs silently fail to come up, e.g. when their firmware
can't be loaded after an initramfs update.
Add a smoke test which enumerates every remoteproc and checks that it
reached the running or attached state. Auto-detect all remoteprocs by
default; set DEVICE to target specific ones.
Some remoteprocs are not booted by the kernel at all, either because no
firmware is shipped for them or because another subsystem owns their
lifecycle, e.g. ath11k for wpss. Skip modem and wpss by default
rather than failing them, and make the list a parameter since it
varies per SoC. Their state is still logged to help triage. Boards
without any remoteproc report remoteproc-device-exists as skip
instead of failing.