automated: linux: wlan-smoke: test all interfaces - #631
Merged
Conversation
Contributor
Author
|
Tested here: https://lava.infra.foundries.io/scheduler/job/330523 |
fboudra
reviewed
Jul 23, 2026
bhcopeland
self-requested a review
July 24, 2026 07:25
bhcopeland
reviewed
Jul 24, 2026
bhcopeland
reviewed
Jul 24, 2026
roxell
reviewed
Jul 30, 2026
Linux/systemd's predictable network interface naming derives the name from how the WiFi chip is attached: PCIe-attached radios get wlpXsY (bus/slot based, e.g. wlp1s0), while SDIO/platform-integrated radios typically keep the kernel default wlanN. So different devices legitimately end up with different interface names. Change logic, make DEVICE empty by default which means discovering every interface under /sys/class/net/*/wireless. Then run the smoke tests against each one. This avoids hardcoding a device name in job definitions. Boards without any wireless interface report wlan-device-exists as skip instead of failing the job. Explicit -d/DEVICE still overrides auto-detection for targeting a single interface. Use check_return instead of exit_on_fail in test_iplink so that a failing interface no longer aborts the whole run, which would leave later interfaces untested while the job still reported green. Keep the plain test case names (ip-link, wlan-boot, wlan-down, wlan-up) so results stay comparable with earlier runs, and put the interface name in the info_msg only. When more than one interface is tested, wrap each in its own lava-test-set to keep the names unique; single-interface runs are unchanged. Signed-off-by: Loïc Minier <loic.minier@oss.qualcomm.com>
fboudra
self-requested a review
August 2, 2026 09:44
bhcopeland
approved these changes
Aug 2, 2026
Contributor
Author
Thanks for the thorough reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux/systemd's predictable network interface naming derives the name from how the WiFi chip is attached: PCIe-attached radios get wlpXsY (bus/slot based, e.g. wlp1s0), while SDIO/platform-integrated radios typically keep the kernel default wlanN. So different devices legitimately end up with different interface names.
Change logic, make DEVICE empty by default which means discovering every interface under /sys/class/net/*/wireless. Then run the smoke tests against each one. This avoids hardcoding a device name in job definitions. Boards without any wireless interface report wlan-device-exists as skip instead of failing the job. Explicit -d/DEVICE still overrides auto-detection for targeting a single interface.