fix(text-embeddings): compare text_encoder_norm_type case-insensitively#504
Open
James D. Finlon (jim-finlon) wants to merge 1 commit into
Open
Conversation
LTX-2.3 distilled checkpoints can serialize text_encoder_norm_type as PER_TOKEN_RMS while the expected value is per_token_rms. Compare string config values case-insensitively while keeping non-string expectations strict. Add pytest coverage for both casings and strict non-string behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
This covers the same distilled checkpoint failure mode as #478, but includes pytest coverage and keeps non-string config validation strict.
Validation