Skip to content

fix(text-embeddings): compare text_encoder_norm_type case-insensitively #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Albatross1382 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(text-embeddings): compare text_encoder_norm_type case-insensitively #478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion text_embeddings_connectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,15 @@ def load_text_embeddings_pipeline(
}
for key, expected_val in _expected.items():
actual = transformer_config.get(key)
assert actual == expected_val, (
# LTX-V checkpoint metadata serialises text_encoder_norm_type as
# the enum name (e.g. "PER_TOKEN_RMS") rather than the value
# ("per_token_rms"). Compare strings case-insensitively; keep
# strict equality for the bool-typed siblings.
if isinstance(expected_val, str) and isinstance(actual, str):
ok = actual.casefold() == expected_val.casefold()
else:
ok = actual == expected_val
assert ok, (
f"Unexpected config for dual-aggregate model: "
f"{key}={actual!r}, expected {expected_val!r}"
)
Expand Down