Skip to content

fix(ci): deploy production site with GitHub Pages Actions - #529

Closed
vitormattos wants to merge 1 commit into
mainfrom
fix/pages-actions-deploy
Closed

vitormattos wants to merge 1 commit into
mainfrom
fix/pages-actions-deploy

Conversation

@vitormattos

Copy link
Copy Markdown
Member

Problem

The production Deploy workflow reports success after pushing the generated site to gh-pages, but the separate legacy GitHub Pages deployment fails. On November 3 the build updated the branch successfully while Pages remained in updating_pages until a 10-minute timeout; the public site still served the October 25 build.

Changes

  • Publish the build as an official Pages artifact and deploy it with actions/deploy-pages, making the deploy result part of the same workflow.
  • Grant only the additional pages: write and id-token: write permissions required for the deployment.
  • Serialize production deployments and reject sites exceeding the documented 1 GB limit.
  • Keep the existing build, source-string sync, deployment metadata and custom domain behavior.

Validation and rollout

  • The code is committed with verified cryptographic signature and DCO.
  • Required after merge: in repository Settings → Pages, set Build and deployment → Source to GitHub Actions. The current source is the legacy gh-pages branch; the new deployment job will not take over until Pages is switched to Actions. The domain libresign.coop must remain configured.
  • Trigger the Deploy workflow (manual dispatch is already enabled), confirm Deploy to GitHub Pages succeeds, then check https://libresign.coop/_deployment-info.json for the new SHA. Do not treat the build alone as proof of publication.

Separate finding

The LibreSign/site-preview deployment branch contains approximately 1.93 GB across 23 PR preview folders; 21 belong to closed PRs. That is a separate GitHub Pages limit failure and requires cleanup of stale preview content. The current preview workflow points to gh-pages; historical failed PR builds used an older revision targeting protected main.

No production merge is performed by this PR.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1-4-g2a6da11

QR code for preview link

🚀 View preview at
https://libresign.github.io/site-preview/pr-preview/pr-529/

Built to branch gh-pages at 2026-11-03 18:16 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@vitormattos vitormattos closed this Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant