Repository navigation
fix: prevent OpenSSL system defaults in signer certificate subjects - #9430
Open
vitormattos wants to merge 2 commits into
Open
vitormattos wants to merge 2 commits into
vitormattos wants to merge 2 commits into
Conversation
Fixes #9366 Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Refactor signer certificate assertions into named data sets and verify that the leaf CSR receives LibreSign's explicit OpenSSL configuration. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Contributor
Code Metrics Report
Details | | main (b02d0b8) | #9430 (2032f12) | +/- |
|---------------------|----------------|-----------------|-------|
+ | Coverage | 76.1% | 76.2% | +0.0% |
| Files | 500 | 500 | 0 |
| Lines | 28578 | 28581 | +3 |
+ | Covered | 21776 | 21780 | +4 |
- | Test Execution Time | 1s | 2s | +1s |Code coverage of files in pull request scope (75.1% → 75.3%, patch 100.0%)
Reported by octocov |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9366: signer CSRs use LibreSign's generated OpenSSL configuration, not the host system
openssl.cnf. That configuration is reused for X.509 certificate signing; issuer-dependent extensions are applied only at signing time.Regression tests
configandreqsection. This fails deterministically if the original unconfiguredopenssl_csr_new()call returns, regardless of the CI worker's system defaults.Validation
C=DEto be inherited from the root. This has been replaced with explicit signer-subject inputs.Previously issued certificates are unchanged. The separate pre-existing root-to-signer field-inheritance behavior is not modified in this PR.