Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .specgit.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
version: 1
delivery: issue409
delivery: issue410
context:
kind: branch
branch: feat/409-issue409
branch: feat/410-issue410
issues:
- 409
pr: 411
- 410
pr: 422
2 changes: 1 addition & 1 deletion packages/opencode/src/dag/review-lifecycle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ export function validateReviewResult(output: unknown, currentFingerprint: string
: ["review result verdict must be ACCEPT or REJECT"]),
...(reviewedFingerprint.trim() === ""
? ["review result must include implementation_fingerprint"]
: reviewedFingerprint === currentFingerprint
: reviewedFingerprint.trim() === currentFingerprint.trim()
? []
: [`review result fingerprint ${reviewedFingerprint} does not match current implementation ${currentFingerprint}`]),
]
Expand Down
32 changes: 32 additions & 0 deletions packages/opencode/test/dag/dag-review-lifecycle.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,38 @@ describe("DAG review lifecycle", () => {
})
})

it("accepts fingerprints that match after trimming surrounding whitespace (issue #410)", () => {
expect(validateReviewResult({
verdict: "ACCEPT",
implementation_fingerprint: "\n sha256:revision-2\n",
}, "sha256:revision-2")).toEqual({
valid: true,
action: "proceed",
reviewed_fingerprint: "\n sha256:revision-2\n",
errors: [],
})
expect(validateReviewResult({
verdict: "ACCEPT",
implementation_fingerprint: "sha256:revision-2",
}, "\n sha256:revision-2\n")).toEqual({
valid: true,
action: "proceed",
reviewed_fingerprint: "sha256:revision-2",
errors: [],
})
expect(validateReviewResult({
verdict: "ACCEPT",
implementation_fingerprint: "sha256:revision 2",
}, "sha256:revision-2")).toEqual({
valid: false,
action: "invalidate",
reviewed_fingerprint: "sha256:revision 2",
errors: [
"review result fingerprint sha256:revision 2 does not match current implementation sha256:revision-2",
],
})
})

it("keeps a deep workflow from succeeding with an unresolved review outcome", () => {
const rejected = workflow("deep", validDiffFlow())
expect(unresolvedReviewOutcomes(rejected, [
Expand Down
Loading