Delivery memory-topic-creation - #398
Merged
Merged
Conversation
LeXwDeX
marked this pull request as ready for review
August 20, 2026 11:18
…d make /memory state truthful #395: openai-compatible downgrades response_format to bare json_object and never sees the streamObject schema, so the maintenance model free-styles a fresh shape every call and validation always rejects — topics are never created. Render the draft-07 JSON Schema ($refs inlined, nullable-union arms simplified) into the system prompt; GenerateError now renders an empty provider error message legibly instead of blank. #396: /memory replies for non-on/off arguments were hardcoded to "Memory remains off"; they now report the true state via Memory.status(). #397: statusReason omits the model gate — an enabled config whose model no longer resolves reads as "Memory on" while Memory is inert. statusReason now returns an actionable model-unavailability reason and a failed /memory on surfaces it instead of a bare "remains off".
LeXwDeX
force-pushed
the
fix/395-memory-topic-creation
branch
from
August 20, 2026 11:19
e3fd048 to
c98e053
Compare
Zero new lint warnings vs the dev baseline (the ratchet cap was exceeded by 5 on CI); behavior identical, guarded by test/memory/model-wire.test.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #395
Closes #396
Closes #397
Why
Summarize the problem or need this delivery addresses.
What changed
Evidence
Checklist
specgit finishexits 0.