[Frontend]: Add skeleton loading for micro-app fetching, and loading feedback for sign-out - #100
Open
MohamadNazik wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #97
Several async operations gave the user no feedback while in flight: fetching the micro-apps list (both in the Store and My Apps screens) and signing out. Users had no indication anything was happening, and could still interact with the tab bar / navigate mid-logout.
Goals
Approach
Skeleton-basedListItemSkeleton/ListItemSkeletonList(row-style, for the Store screen's list layout) andWidgetSkeleton/WidgetSkeletonGrid(grid-style, for the My Apps screen's icon-grid layout) components.useStore.ts: fixed a bug whereloadMicroAppDetails()was called withoutawait, soisLoadingwas reset before the fetch actually completed — the skeleton had no real time window to render regardless of fetch duration.useMyApps.ts: added anisLoadingstate around the initial fetch, which previously had no loading state at all.authSlice.ts: addedisLoggingOutstate +setLoggingOutaction;performLogout.tsdispatches it at the start/on error of the logout thunk (success path resets via the existingresetAll()).profile.tsx: Sign Out button shows a spinner + "Signing Out..." and is disabled while logging out.(tabs)/_layout.tsx: renders an absolutely-positioned transparent overlay over the tab bar whileisLoggingOutis true, blocking all touches there regardless of the tab bar's internal press-handling. (An earlier attempt usingtabBarButton'sdisabledprop didn't reliably block navigation in testing, so the overlay is the actual guard.)No UI changes to the native splash/app icon or other unrelated screens.
User stories
As a user, when I open the Store or My Apps screen, I see a loading skeleton instead of a blank screen while data loads. When I sign out, I see clear feedback that it's in progress and can't accidentally navigate away mid-process.
Release note
Added skeleton loading states for micro-app fetching (Store and My Apps screens) and loading feedback (spinner + disabled tab bar) during sign-out.
Automation tests
Security checks
Test environment
Tested on a physical Android device via an EAS development build.