GH-90: feat:Build/Enable Blog section in the website - #91
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
📝 WalkthroughWalkthroughThe site now provides a data-driven blog page with responsive article cards, pagination, three new posts, and desktop/mobile navigation links. The shared blog component replaces the previous inline article template. A board member photo path was corrected. ChangesBlog page migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant Browser
participant Jekyll
participant PostsData
Browser->>Jekyll: Request /blog/
Jekyll->>PostsData: Read site.data.posts
PostsData-->>Jekyll: Return post metadata
Jekyll-->>Browser: Render blog cards
Browser->>Browser: Apply pagination when more than six posts
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@blog.html`:
- Around line 79-90: Update the pagination controls identified by prev-btn,
next-btn, and the dynamically generated page buttons: add accessible labels to
the navigation buttons, replace the focus:outline-none focus:ring-0 styling with
a visible keyboard focus style, and apply aria-current="page" only to the
currently selected page button.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 65e09c0d-9ae8-430b-a6e4-e7b17bf764c9
⛔ Files ignored due to path filters (2)
images/.DS_Storeis excluded by!**/.DS_Storeimages/sanjiva.jpegis excluded by!**/*.jpeg
📒 Files selected for processing (6)
_data/board.yml_data/posts.yml_includes/header.htmlblog.htmlblog.mdblogs.html
💤 Files with no reviewable changes (2)
- blogs.html
- blog.md
🚧 Files skipped from review as they are similar to previous changes (3)
- _data/board.yml
- _data/posts.yml
- _includes/header.html
ChanukaUOJ
changed the title
ChanukaUOJ
changed the title
|
@sanjiva Hi Sanjiva! We had a discussion about making all blog articles published by LDF directly accessible through our official website allowing users to find everything in one place. This PR introduces the new |
There was a problem hiding this comment.
Does using markdown header matter work with .html files?
Why not just keep this in blog.md?
There was a problem hiding this comment.
Noted and fixed! I have moved the blog.md to the root level and linked the UI component through blog.html for better separation of concerns.
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
blog.md (1)
1-7: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick winSet
blog.mdtopermalink: /blog/.The global permalink setting does not apply this standalone page. Jekyll otherwise outputs
blog.mdas/blog.html, while navigation links to/blog/, causing a 404.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@blog.md` around lines 1 - 7, Update the front matter in blog.md to explicitly set the page permalink to /blog/. Preserve the existing layout, title, description, and blog.html include.
🧹 Nitpick comments (1)
_includes/blog.html (1)
111-149: 🎯 Functional Correctness | 🔵 Trivial | 🏗️ Heavy liftAdd regression coverage for the pagination boundary.
Test 0, 1, 6, 7, and 12 articles. Verify result bounds, active-page state, and previous/next button state.
Also applies to: 151-181
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@_includes/blog.html` around lines 111 - 149, Add regression tests for initPagination and the related showPage pagination flow covering 0, 1, 6, 7, and 12 articles. Assert displayed result bounds, active-page state, and previous/next button enabled or disabled state for each boundary and page scenario.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@blog.md`:
- Around line 1-7: Update the front matter in blog.md to explicitly set the page
permalink to /blog/. Preserve the existing layout, title, description, and
blog.html include.
---
Nitpick comments:
In `@_includes/blog.html`:
- Around line 111-149: Add regression tests for initPagination and the related
showPage pagination flow covering 0, 1, 6, 7, and 12 articles. Assert displayed
result bounds, active-page state, and previous/next button enabled or disabled
state for each boundary and page scenario.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 16ef6e71-a6b8-4e54-ab72-ccdb07c0652c
📒 Files selected for processing (2)
_includes/blog.htmlblog.md
There was a problem hiding this comment.
Why do all these blogs have a date of 2026-02-04??
Please put the correct dates.
There was a problem hiding this comment.
@sanjiva we published all 3 articles on the same day as our release on 2026-02-04.
3 participants
This PR Closes: #90
Changes
New View
Summary by CodeRabbit
New Features
Bug Fixes