Skip to content

fix(Makefile): detect bin of nightly nvim installed via scoop #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xudyang1 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(Makefile): detect bin of nightly nvim installed via scoop #1447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
988141a
fix(Makefile): detect bin of nightly nvim installed via scoop
xudyang1 Jul 7, 2026
c8ddddd
Auto generate docs
xudyang1 Jul 7, 2026
559e77e
fix: update spellwords to pass ci
xudyang1 Jul 7, 2026
9117719
Auto generate docs
xudyang1 Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,19 +80,24 @@ else ifneq (,$(or $(findstring $(WINDOWS_NT),$(LUASNIP_DETECTED_OS)), $(findstri
# If neovim is installed by scoop, only scoop/shims is exposed. We need to find original nvim/bin that contains lua51.dll
# If neovim is installed by winget or other methods, nvim/bin is already included in PATH.

# `scoop prefix neovim` outputs either
# 1. C:\Users\MyUsername\scoop\apps\neovim\current
# 2. Could not find app path for 'neovim'.
# `scoop prefix neovim` outputs:
# found: stable: `C:\Users\MyUsername\scoop\apps\neovim\current`
# nightly or not found: `Could not find app path for 'neovim'.`
# `scoop which nvim` outputs:
# found: stable: `~\scoop\apps\neovim\current\bin\nvim.exe` or nightly: `~\scoop\apps\neovim-nightly\current\bin\nvim.exe`
# not found: `WARN 'nvim' not found, not a scoop shim, or a broken shim.`
# To include lua51.dll, we need: `C:/Users/MyUsername/scoop/apps/neovim[-nightly]/current/bin`
#
# On Git Bash, scoop returns 0 and writes error to stdout in case 2. This is tracked by
# @link: https://github.com/ScoopInstaller/Scoop/issues/6228
# The following code will also work if future scoop returns 1 for unknown `package`
#
# On Git Bash, `which nvim` returns a Unix style path: `/c/Program Files/Git/bin/nvim`
# On Git Bash, `command -v nvim` returns a Unix style path: `/c/Program Files/Git/bin/nvim`
# Always convert to `C:/Program Files/Git/bin/nvim` for powershell and pwsh users
NEOVIM_BIN_PATH:=$(or \
$(shell (scoop prefix neovim | grep -q '^[A-Z]:[/\\\\]') 2>/dev/null && \
echo "$$(scoop prefix neovim)/bin" | sed 's/\\\\/\\//g';), \
$(shell which nvim >/dev/null && dirname "$$(which nvim)" | sed 's/^\\/\\(.\\)\\//\\U\\1:\\//';) \
$(shell (scoop which nvim | grep -q 'nvim.exe$$') && \
scoop which nvim | sed -e 's|\\\\|/|g' -e "s|^~|$(subst \,/,$(USERPROFILE))|" -e 's|/nvim.exe$$||';), \
$(shell dirname "$$(command -v nvim)" | sed 's/^\\/\\(.\\)\\//\\U\\1:\\//';) \
)
# Always double quote the absolute path as it may contain spaces
LUA_LDLIBS?=$(if $(NEOVIM_BIN_PATH),-L'$(NEOVIM_BIN_PATH)' -llua51,)
Expand Down
3 changes: 3 additions & 0 deletions data/project-dictionary.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,3 +129,6 @@ treesitter
truthy
varargs
vsnip
FreeBSD
Makefile
gmake
2 changes: 1 addition & 1 deletion doc/luasnip.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
*luasnip.txt* For NeoVim 0.9-0.11 Last change: 2026 May 19
*luasnip.txt* For NeoVim 0.9-0.11 Last change: 2026 July 07

==============================================================================
Table of Contents *luasnip-table-of-contents*
Expand Down
Loading