Aligned column name clashing handling across different IO#1904
Open
AndreiKingsley wants to merge 8 commits into
Open
Aligned column name clashing handling across different IO#1904AndreiKingsley wants to merge 8 commits into
AndreiKingsley wants to merge 8 commits into
Conversation
Jolanrensen
reviewed
Jun 19, 2026
|
|
||
| /** [Auto-renaming columns in DataFrame][AutoRenamingColumnsInDataFrame] */ | ||
| internal typealias AutoRenamingLink = Nothing | ||
| internal typealias AutoRenameInputSnippet = Nothing |
Collaborator
Author
There was a problem hiding this comment.
Should be used in IO modules, after kodex fix
| * | ||
| * ## Auto-renaming columns in [DataFrame] | ||
| * | ||
| * [DataFrame] can not contain columns with duplicate names. |
Collaborator
There was a problem hiding this comment.
no clue why, English is weird
| * using the pattern `"\$name\$n"`, where `name` is the original column name | ||
| * and `n` is a unique index (1, 2, 3, and so on); | ||
| * the first time the name of the column is encountered, no number is appended. | ||
| * |
Collaborator
There was a problem hiding this comment.
maybe it's clearer to move the sample here. For example: "name", "name1", "name2", etc. That may be clearer :)
| import kotlin.annotation.AnnotationTarget.TYPEALIAS | ||
| import kotlin.annotation.AnnotationTarget.VALUE_PARAMETER | ||
|
|
||
| // TODO use KDoc-helpers from :core |
Collaborator
There was a problem hiding this comment.
Try this in the build.gradle.kts. I remembered I built some system for adding contextual sources for KoDEx :P
kodexConvention {
contextualSourcesDirectories =
project(projects.core.path)
.sourceSets
.main.get()
.allSource
}
tasks.processKDocsMain {
dependsOn(project(projects.core.path).tasks.assemble)
}
Jolanrensen
reviewed
Jun 19, 2026
|
|
||
| private const val MESSAGE_REMOVE_1_1 = "Will be removed in 1.1." | ||
| internal const val READ_EXCEL_OLD = "This function is only here for binary compatibility. $MESSAGE_REMOVE_1_1" | ||
| internal const val NAME_REPAIR_STRATEGY: String = |
Collaborator
There was a problem hiding this comment.
We don't have a system yet for tracking deprecations in other modules than core, but maybe we could mirror the same structure?
Collaborator
Author
There was a problem hiding this comment.
How exactly?
Collaborator
There was a problem hiding this comment.
in util/deprecationMessages.kt I mean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #387.
Now
ColumnNameGeneratoris used in all IO implementations, behavior is aligned.Deprecated Excel approach. Added a snippet about behavior in IO KDocs.
Added kodex to IO modules.