test(viewer): help_overlay + settings_tab proptest surfaces (WBS-6.2 #455 #456) - #470
test(viewer): help_overlay + settings_tab proptest surfaces (WBS-6.2 #455 #456)#470KooshaPari wants to merge 2 commits into
Conversation
Adds crates/sl-viewer/tests/properties_viewer_help_overlay.rs with 13 proptest properties pinning the keyboard help SSOT: * SHORTCUTS is non-empty. * Every shortcut has non-empty keys / scope / action. * Every action is descriptive (has at least one ASCII letter) and human-readable (no ERR_ / error code leaks). * Every (keys, scope) pair is unique so the rendered table does not collide on its React key. * The ?, Escape, and Cmd+K / Ctrl+K shortcuts are present. * Every scope is one of the documented panel scopes. * Every keys is non-blank. Updates WBS-6.2 evidence list, TRACEABILITY.json, and CHANGELOG.
Adds crates/sl-viewer/tests/properties_viewer_settings_tab.rs with 11 proptest properties pinning the settings tab SSOT: * HealthStatus::Unknown.label() is , Healthy is , Unreachable is . * Every label is non-empty, distinct across variants, single-line, and lowercase ASCII. * label() is deterministic across calls. * THEME_RADIO_GROUP_ID is non-empty, kebab-case ASCII, and distinct from FORGE_DB_HINT_STORAGE_KEY. Updates WBS-6.2 evidence list, TRACEABILITY.json, and CHANGELOG.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reached
Next review available in: 57 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:L
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| // appear under multiple scopes (e.g. `Escape` is a multi-scope | ||
| // close). We assert that at least one key appears more than once | ||
| // is reasonable; the strong check is the (keys, scope) pair. | ||
| let _ = (keys.len(), SHORTCUTS.len()); |
There was a problem hiding this comment.
WARNING: shortcuts_keys_unique is a no-op — it discards its computation without asserting anything.
The let _ = (keys.len(), SHORTCUTS.len()); line creates a tuple and immediately drops it. The test always passes regardless of whether keys are unique or not. If the intent is to verify that at least one key appears in multiple scopes, use prop_assert!(keys.len() < SHORTCUTS.len(), ...). If uniqueness is required, use prop_assert_eq!(keys.len(), SHORTCUTS.len()). As written, this test provides zero verification.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (4 files)
Fix these issues in Kilo Cloud Reviewed by step-3.7-flash · Input: 53K · Output: 9.5K · Cached: 141.3K |
User description
Summary
Two property-test surfaces consolidated on a single branch:
crates/sl-viewer/tests/properties_viewer_help_overlay.rs(WBS-6.2 #455)13 proptest properties pinning
help_overlay::SHORTCUTSinvariants:SHORTCUTSis non-empty.keys/scope/action.actionis descriptive (has at least one ASCII letter) and human-readable (noERR_/error codeleaks).(keys, scope)pair is unique.?help toggle,Escapeclose, andCmd+K / Ctrl+Kcommand palette shortcuts are present.scopeis one of the documented panel scopes.keysis non-blank.crates/sl-viewer/tests/properties_viewer_settings_tab.rs(WBS-6.2 #456)11 proptest properties pinning
settings_tab::HealthStatusenum +THEME_RADIO_GROUP_IDSSOT:HealthStatus::Unknown/Healthy/Unreachablelabel()values match the documented strings.THEME_RADIO_GROUP_IDis non-empty, kebab-case ASCII, distinct fromFORGE_DB_HINT_STORAGE_KEY.Validation
cargo test -p sl-viewer --test properties_viewer_help_overlay --features "desktop parquet" --locked— 13 passedcargo test -p sl-viewer --test properties_viewer_settings_tab --features "desktop parquet" --locked— 11 passedcargo fmt --all --check— cleanWBS / TRACEABILITY
WBS-6.2 evidence list and
TRACEABILITY.jsongain both new files. CHANGELOG Unreleased documents both surfaces.CodeAnt-AI Description
Add property-test coverage for viewer shortcuts and settings status labels
What Changed
checking,healthy, andunreachablevalues.Impact
✅ Fewer broken or misleading help-overlay shortcuts✅ Clearer settings health status labels✅ More reliable theme-control and test selectors💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.