Support chained expectations in MockClient#566
Merged
Conversation
ryber
approved these changes
May 5, 2026
Collaborator
|
Thanks, I have a few housekeeping things I'm going to add and then I will cut a release. This will need to be a minor bump since it does change behavior and may cause failing tests for some users |
Author
|
Thanks! That makes sense. I agree this is a behavior change, so a minor version bump sounds appropriate. Glad to see it will be included in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for chained
MockClientexpectations when multiple expectations are registered for the same request.Motivation
Previously, duplicate expectations for the same method/path could result in the later expectation overriding the earlier one. This made it difficult to model ordered responses for repeated calls to the same endpoint.
Fixes #531.
Changes
Testing
mvn -pl unirest-modules-mocks test