Sequence: reset mIsRunning on exception from submit/waitForFences#461
Open
mgajda wants to merge 1 commit intoKomputeProject:masterfrom
Open
Sequence: reset mIsRunning on exception from submit/waitForFences#461mgajda wants to merge 1 commit intoKomputeProject:masterfrom
mgajda wants to merge 1 commit intoKomputeProject:masterfrom
Conversation
When vkQueueSubmit or vkWaitForFences throws (e.g. vk::DeviceLostError on GPU TDR), leaving mIsRunning=true deadlocks the next evalAsync() call in the 'already running' guard. Catch-and-rethrow so the state is cleared and the exception still propagates to the caller. Fixes KomputeProject#459.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #459.
mIsRunningis set true beforevkQueueSubmit/vkWaitForFencesbut not reset on throw, deadlocking the next call. Catch-and-rethrow clears it; the exception propagates unchanged.Supersedes #460.