Repository navigation
chore(tui): remove stale TCSS selectors - #1266
Merged
Merged
Conversation
#filterable-task-table and #table-title match no widget id anywhere in the codebase. Refs #1160
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR removes three stale TCSS selectors (#filterable-task-table, #filterable-task-table:focus-within, and #table-title) that are no longer referenced by any widget in the codebase. The changes are pure dead-code deletion with no logic, security, or functional concerns.
Both files are clean after the removal, and the remaining selectors are unaffected. No blocking defects found — this PR is safe to merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes item 3 of #1160:
#filterable-task-table(and its:focus-withinrule) incomponents.tcss, and#table-titleinmain.tcss. No widget intaskdog-ui/srcor its tests uses either id (grep, including dynamically built ids).Verification:
make test-uipasses, includingtest_keybindings, which boots the fullTaskdogTUIviarun_test()and therefore parses the app's TCSS.Items 1–2 of #1160 remain open.
Refs #1160