fix(auth): require secret for internal service mode - #12
Open
PranavaKCode wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e7fe789ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MANTIS_INTERNAL_SERVICE_SECRETinto the SDK configurationX-Internal-Secretwith the existing internal-service marker and user IDMotivation and context
MantisAPI PR #2442 replaced the spoofable marker-only bypass with an authenticated
X-Internal-Secretcontract. SDK callers usingMANTIS_INTERNAL_USER_IDmust send that same provisioned secret or their requests fall through to browser authentication.Fixes #11.
This is intentionally fail-closed: the SDK accepts a provisioned secret but never derives or logs it. Cookie authentication is unchanged.
How has this been tested?
python -m ruff check .uv run --with pytest --with pytest-asyncio pytest -q(71 tests passed)git diff --checkScreenshots (if appropriate):
Not applicable; this is an SDK authentication contract change.
Types of changes
Checklist:
ruff check. There are no style warnings. [REQUIRED]pytest. All new and existing tests passed. [REQUIRED]