Conversation
Removed webExperimentFactory, webExperiment, and all GraphQL dependencies from the codebase: Code changes: - dataObjectsFactory.py: removed webExperimentFactory class and gql imports - dataObjects.py: removed webExperiment class, removed client/url properties from Experiment/TrialSet/Trial/EntityType, removed requests/BytesIO imports, base getImage now raises NotImplementedError, base _init_ImageMaps is a no-op (overridden by ExperimentZipFile) - __init__.py (experimentSetup): removed WEB constant and getExperimentSetup function, removed webExperimentFactory import - __init__.py (argos): removed WEB import Deleted files: - argos/examples/web/ (web experiment examples) - argos/experimentSetup/.ipynb_checkpoints/ (stale checkpoint) Documentation updates: - Removed all webExperimentFactory/webExperiment/GraphQL references from 9 doc pages (API, architecture, data model, user guide) - Removed "Loading from Web" swimlane diagram - Updated class diagrams, dependency matrix, module maps - Changelog left as-is (historical) Tests: 99 passed, 10 xfailed (unchanged) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed
webExperimentFactory,webExperiment,getExperimentSetup, and all GraphQL (gql) dependencies.Code
dataObjectsFactory.py— removedwebExperimentFactoryclass (350 lines),gqlimportsdataObjects.py— removedwebExperimentclass,client/urlproperties from all classes,requests/BytesIOimportsexperimentSetup/__init__.py— removedWEBconstant andgetExperimentSetup()functionargos/__init__.py— removedWEBimportargos/examples/web/and.ipynb_checkpoints/Docs
Test plan
pytest— 99 passed, 10 xfailedmkdocs build— clean buildimport argos— works,WEBno longer exported🤖 Generated with Claude Code