Skip to content

test(server): harden raw trailer read on Windows#1270

Merged
quinnj merged 1 commit into
masterfrom
codex/windows-raw-read-hardening
Jun 1, 2026
Merged

test(server): harden raw trailer read on Windows#1270
quinnj merged 1 commit into
masterfrom
codex/windows-raw-read-hardening

Conversation

@quinnj
Copy link
Copy Markdown
Member

@quinnj quinnj commented Jun 1, 2026

Summary

  • add an opt-in first-byte wait for raw HTTP test probes
  • use it for the chunked trailers stream test that previously observed an empty raw response on Windows

Notes

The #1261 Windows failure saw raw == "" in the trailers assertion path. This keeps normal raw probes unchanged, but lets response-sensitive probes avoid treating a pre-response empty read as completion.

Validation

Refs #1261

Co-authored by Codex

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.37%. Comparing base (83f4873) to head (06db385).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1270      +/-   ##
==========================================
- Coverage   84.51%   84.37%   -0.15%     
==========================================
  Files          28       28              
  Lines       10690    10690              
==========================================
- Hits         9035     9020      -15     
- Misses       1655     1670      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@quinnj quinnj merged commit 15c8238 into master Jun 1, 2026
7 of 8 checks passed
@quinnj quinnj deleted the codex/windows-raw-read-hardening branch June 1, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant