test(server): harden raw trailer read on Windows#1270
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1270 +/- ##
==========================================
- Coverage 84.51% 84.37% -0.15%
==========================================
Files 28 28
Lines 10690 10690
==========================================
- Hits 9035 9020 -15
- Misses 1655 1670 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
The #1261 Windows failure saw
raw == ""in the trailers assertion path. This keeps normal raw probes unchanged, but lets response-sensitive probes avoid treating a pre-response empty read as completion.Validation
codecov/patchpassed,codecov/projectremains redjulia --project=. --startup-file=no --history-file=no test/http_server_http1_tests.jlgit diff --checkRefs #1261
Co-authored by Codex