support transparency

[t-bltg]

Fix #17.

PR (mlterm)

master

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@07011d3). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #18   +/-   ##
=========================================
  Coverage          ?   41.19%           
=========================================
  Files             ?       10           
  Lines             ?      352           
  Branches          ?        0           
=========================================
  Hits              ?      145           
  Misses            ?      207           
  Partials          ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[t-bltg]

@johnnychen94 ?

[johnnychen94]

Sorry I missed it.

Would you mind adding a test for this?

[t-bltg]

Regarding the tests, there is something fundamentally fishy with src/terminaltools.jl: query_terminal requires stdin fd to be opened, and under the tests, stdin is closed since tests are ran under non interactive mode, so testing is not representative.
==> side effect of JuliaLang/Pkg.jl#3065.

I couldn't find a way to fake stdin when querying sixel support, so I'm a bit stuck here @johnnychen94.

[johnnychen94]

Why would you need the interactive mode to run the test? I mean, it's more or less like how

Sixel.jl/test/backend/libsixel.jl

Lines 60 to 63 in 07011d3

	for img in (
	repeat(Gray.(0:0.1:0.9), inner=(10, 50)),
	repeat(distinguishable_colors(10), inner=(10, 50))
	)

does for RGBA, right?

img = rand(RGBA, 5, 5)
io = IOBuffer()
sixel_encode(io, img)
@test ref == String(take!(io))

[t-bltg]

I got confused by

Sixel.jl/test/runtests.jl

Line 9 in 07011d3

sixel_output || @info "Current terminal does not support sixel format sequence. Display tests to stdout will be marked as broken."

[johnnychen94]

sixel_encode supports three outputs:

• sixel_encode(img): println to stdout. This requires interactive mode (actually not, but CI environment doesn't support sixel)
• sixel_encode(::IO, img)

It's okay to use IOBuffer to get the encoded sequence and test against it.

[t-bltg]

Last commit is optional, let me know I you don't want it.

[t-bltg]

Let's put this on hold since the real fix would (hopefully) be brought by libsixel/libsixel#23.

I'm planning of bumping libsixel to 1.10.3 (JuliaPackaging/Yggdrasil#5432 - might require running gen/generator.jl here).

[ctrlcctrlv]

@t-bltg Perhaps we should work together instead of separately, as I got a bit scared off by all the memory safety issues in libsixel so have been afraid to make big changes to the C code, especially because we know for a fact the current API's aren't even able to be made safe as a few of them lack critical information like data size.

I don't know Julia, sorry, but my longterm plan upstream has been to:

• switch the core library to another language, probably Rust if I were to be its main developer as that's the language I know best for systems programming;
• write a C ABI mimicking the existing C API.

[t-bltg]

That's certainly a good idea to transition to rust if you want something similar to current c interface. I must admit I never wrote rust code (lots of Fortran and C, and obviously julia) ;). But if I can help in any way ...