Skip to content

Fix symv!/hemv! and symm!/hemm! dispatch for unsupported eltypes. #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maleadt merged 1 commit into from
Jun 10, 2026
Merged

Fix symv!/hemv! and symm!/hemm! dispatch for unsupported eltypes. #577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions lib/mkl/linalg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,15 @@ function LinearAlgebra.generic_matvecmul!(Y::oneVector, tA::AbstractChar, A::one
if T <: onemklFloat && eltype(A) == eltype(B) == T
if tA in ('N', 'T', 'C')
return gemv!(tA, alpha, A, B, beta, Y)
elseif tA in ('S', 's')
elseif tA in ('S', 's') && T <: Real
# complex symv! is not wrapped; fall through to generic_matmatmul!,
# which can use symm! instead
return symv!(tA == 'S' ? 'U' : 'L', alpha, A, B, beta, Y)
elseif tA in ('H', 'h')
return hemv!(tA == 'H' ? 'U' : 'L', alpha, A, B, beta, Y)
# hemv! only supports complex eltypes, but a real Hermitian matrix
# is symmetric
fun = T <: Real ? symv! : hemv!
return fun(tA == 'H' ? 'U' : 'L', alpha, A, B, beta, Y)
end
end
end
Expand Down Expand Up @@ -162,14 +167,20 @@ function LinearAlgebra.generic_matmatmul!(
A isa oneStridedArray{T} && B isa oneStridedArray{T}
)
return gemm!(tA, tB, α, A, B, β, C)
elseif (tA == 'S' || tA == 's') && tB == 'N'
return symm!('L', tA == 'S' ? 'U' : 'L', α, A, B, β, C)
elseif (tB == 'S' || tB == 's') && tA == 'N'
return symm!('R', tB == 'S' ? 'U' : 'L', α, B, A, β, C)
elseif (tA == 'H' || tA == 'h') && tB == 'N'
return hemm!('L', tA == 'H' ? 'U' : 'L', α, A, B, β, C)
elseif (tB == 'H' || tB == 'h') && tA == 'N'
return hemm!('R', tB == 'H' ? 'U' : 'L', α, B, A, β, C)
elseif T <: onemklFloat && A isa oneStridedArray{T} && B isa oneStridedArray{T}
# hemm! only supports complex eltypes, but a real Hermitian matrix
# is symmetric
if (tA == 'S' || tA == 's') && tB == 'N'
return symm!('L', tA == 'S' ? 'U' : 'L', α, A, B, β, C)
elseif (tB == 'S' || tB == 's') && tA == 'N'
return symm!('R', tB == 'S' ? 'U' : 'L', α, B, A, β, C)
elseif (tA == 'H' || tA == 'h') && tB == 'N'
fun = T <: Real ? symm! : hemm!
return fun('L', tA == 'H' ? 'U' : 'L', α, A, B, β, C)
elseif (tB == 'H' || tB == 'h') && tA == 'N'
fun = T <: Real ? symm! : hemm!
return fun('R', tB == 'H' ? 'U' : 'L', α, B, A, β, C)
end
end
end

Expand Down
Loading