Repository navigation
Report missing note columns with ArgumentError - #6
Merged
Merged
Conversation
Interpolate the requested column rather than an undefined variable in the existing error path. Cover Symbol, String and zero-index requests and retain existing table and column notes after those errors. AI disclosure: This work was prepared with assistance from OpenAI Codex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requesting a note for a missing column currently throws
UndefVarError: col not defined. The existing invalid-column check refers to the wrong variable while preparing its error message.Use the requested
columnin that message so the intendedArgumentErroris returned. Regression checks cover absent Symbol/String names, signed/unsigned zero indices and preserved table/column notes after errors.Validation: both unchanged runtime probes reproduce the wrong error on actual Julia 1.6.7 and 1.13.1. Full suites pass 97 checks on both versions after integrating the merged minimum-runtime repair, including 11 new regressions. The tested tree is unchanged after rebasing onto actual main.
git diff --checkpasses. All three exact-head hosted CI jobs pass at5db302ba4ed23dac7ecf9362e673591add716987(run37209920412), with four threads and bounds checking. The normal merge is42624bc67f1c521b953b21ff8dc81d0180de94ff; all three exact-main jobs also pass (run37210566148).Co-authored by Codex
AI disclosure: This work was prepared with assistance from OpenAI Codex.