Repository navigation
Restore metadata style helpers on Julia 1.6 - #5
Merged
Merged
Conversation
Use constant one-argument predicates instead of a Base helper absent on the declared minimum Julia version. Run the existing package suite on minimum, current and nightly Julia in CI. AI disclosure: This work was prepared with assistance from OpenAI Codex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default metadata-style helpers throw
UndefVarError: Returns not definedon the package's supported Julia 1.6 runtime. Use ordinary constant predicates for those three wrappers and run the existing suite on Julia 1.6, current stable and nightly.The repository has no test workflow. This adds a small read-only CI job with the verified checkout/setup/cache action references, four threads and the test action's default bounds checking. The declared Julia minimum and dependencies stay as they are.
Validation: the unchanged main reproduces the helper error on actual Julia 1.6.7. With the three-line source fix, the full existing suite passes 86 checks on actual Julia 1.6.7 and 1.13.1.
git diff --checkpasses. All three exact-head CI jobs pass ate654fc71fe5d41cf60f42ef9ca3bb157aa6b2cf8(run37209310967), including the declared minimum, current stable and nightly. The logs confirm bounds checking and four threads.Merged normally as
9d902fb4886d5894cd8539c3b9a01a1ceb7ae099. All three exact-main CI jobs also pass (run37209764456).The independently reproduced missing-column note error and column-style selection issue are separate follow-ups.
Co-authored by Codex
AI disclosure: This work was prepared with assistance from OpenAI Codex.