Repository navigation
Conversation
Insert a singleton group for each unique index instead of reading an undefined container or comparing keys with equality. AI disclosure: This work was prepared with assistance from OpenAI Codex.
Use scoped GitHub OIDC for repository branches and preserve the tokenless fork path. Keep the existing test matrix and coverage configuration. AI disclosure: This work was prepared with assistance from OpenAI Codex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
groupfindnow accepts nonemptyDictionaries.Indicesinputs. Previously, the index-set method referred to an undefinedcontainerand threw an error before returning any groups.Each unique index now produces its own singleton group. This preserves key order and handles
missing,NaN, and distinct signed zeros without comparing a key to itself with==.Validation: the focused reproducer changed from 1 passing and 7 erroring checks to all 8 passing on Julia 1.10.12 and 1.13.1. The full native suite passes all 222 assertions on both versions. The Julia 1.10 run also uses Dictionaries 0.3.0, the oldest release allowed by the package's compatibility range. All four hosted native test jobs pass at
a30c02982ee9a67df1dc7a8270eb8efa6e981fbe. All four coverage uploads are accepted for this repository and commit, and Codecov has processed all four reports (74.95%). An independent approving GitHub review is still required before merge.CI also authenticates coverage uploads with GitHub OIDC on repository branches and fails when an upload is rejected. The previous uploader rejected reports for the protected branch while still reporting a successful job.
Co-authored by Codex
AI disclosure: This work was prepared with assistance from OpenAI Codex.