build(java module): Fix Java Module to build on any platform - #19
Open
Jeff Retz (DatL4g) wants to merge 35 commits into
Open
build(java module): Fix Java Module to build on any platform#19Jeff Retz (DatL4g) wants to merge 35 commits into
Jeff Retz (DatL4g) wants to merge 35 commits into
Conversation
The previous implementation required the java module to be built on macOS.
Collaborator
|
Hi Jeff Retz (@DatL4g), I can't build it on Windows. Probably in linux it'd be the same |
Applied previous code to fix jcef build system
Author
|
Vladimir Kharitonov (@ujpv) seems like your build process differs from mine. Applied previous code to fix this build system, should work now. |
Collaborator
|
Still not possible to build |
Added missing InvocationTargetException import
Author
|
Vladimir Kharitonov (@ujpv) finding all required packages to build on Fedora was a pain, maybe add them to the README.md However fixed now, were missing imports only. |
break loop early (like before) if required instance is found
# Conflicts: # .github/ISSUE_TEMPLATE/bug_report.md # CMakeLists.txt # README.md # java/org/cef/CefClient.java # java/org/cef/handler/CefLoadHandler.java # java_tests/tests/junittests/TestFrame.java # native/CMakeLists.txt # native/CefBrowser_N.cpp # native/browser_process_handler.h # tools/make_docs.sh # tools/run.sh
Vladimir Kharitonov (ujpv)
force-pushed
the
dev
branch
from
November 18, 2023 00:38
d1ef9e7 to
d6a2c6a
Compare
Vladimir Kharitonov (ujpv)
force-pushed
the
dev
branch
2 times, most recently
from
November 19, 2023 19:10
3140784 to
80e85e7
Compare
Vladimir Kharitonov (ujpv)
force-pushed
the
dev
branch
from
November 19, 2023 19:13
80e85e7 to
ca4de13
Compare
artemm-bochkarev
force-pushed
the
dev
branch
5 times, most recently
from
February 25, 2024 15:06
416fc38 to
4628cac
Compare
artemm-bochkarev
force-pushed
the
dev
branch
3 times, most recently
from
March 4, 2024 21:08
d1e1b73 to
cd51a5e
Compare
artemm-bochkarev
force-pushed
the
dev
branch
from
November 26, 2024 10:39
78ddb67 to
96e1c62
Compare
Vladimir Kharitonov (ujpv)
force-pushed
the
dev
branch
from
January 2, 2025 18:45
9b1f2e2 to
d51a12a
Compare
artemm-bochkarev
force-pushed
the
dev
branch
from
February 24, 2025 11:24
0cb3bf8 to
cf102eb
Compare
artemm-bochkarev
force-pushed
the
dev
branch
2 times, most recently
from
March 17, 2025 12:21
d89f9fc to
bad1142
Compare
artemm-bochkarev
force-pushed
the
dev
branch
3 times, most recently
from
May 21, 2025 04:31
0a0f27b to
5b8f7f1
Compare
artemm-bochkarev
force-pushed
the
dev
branch
2 times, most recently
from
July 31, 2025 16:49
1760523 to
73d630b
Compare
artemm-bochkarev
force-pushed
the
dev
branch
from
December 16, 2025 12:14
6f11d26 to
73b0a48
Compare
Vladimir Kharitonov (ujpv)
force-pushed
the
dev
branch
from
August 11, 2026 18:06
80b7659 to
a89ba66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation required the java module to be built on macOS.
Before it loaded the browser handle class on mac only and that dynamically, which is kind of ridiculous, in addition that did nothing to handle building on different platforms.