Skip to content

build(java module): Fix Java Module to build on any platform - #19

Open
Jeff Retz (DatL4g) wants to merge 35 commits into
JetBrains:devfrom
DatL4g:upstream-fix
Open

build(java module): Fix Java Module to build on any platform#19
Jeff Retz (DatL4g) wants to merge 35 commits into
JetBrains:devfrom
DatL4g:upstream-fix

Conversation

@DatL4g

Copy link
Copy Markdown

The previous implementation required the java module to be built on macOS.

Before it loaded the browser handle class on mac only and that dynamically, which is kind of ridiculous, in addition that did nothing to handle building on different platforms.

@ujpv

Copy link
Copy Markdown
Collaborator

Hi Jeff Retz (@DatL4g), I can't build it on Windows. Probably in linux it'd be the same

    [javac] Compilation arguments:
    [javac] '-J-Xms32m'
    [javac] '-J-Xmx128m'
    [javac] '-nowarn'
    [javac] '-d'
    [javac] 'C:\develop\jcef_rpc_keyboard_master\out\win64'
    [javac] '-classpath'
    [javac] 'C:\develop\jcef_rpc_keyboard_master\out\win64;C:\develop\jcef_rpc_keyboard_master\third_party\jogamp\jar\gluegen-rt-natives-macosx-universal.jar;C:\develop\jcef_rpc_keyboard_master\third_party\jogamp\jar\gluegen-rt.jar;C:\develop\jcef_rpc_keyboard_master\third_party\jogamp\jar\jogl-all-natives-macosx-universal.jar;C:\develop\jcef_rpc_keyboard_master\third_party\jogamp\jar\jogl-all.jar'
    [javac] '-sourcepath'
    [javac] 'C:\develop\jcef_rpc_keyboard_master\java'
    [javac] '-encoding'
    [javac] 'UTF8'
    [javac] '-g'
    [javac] '-XDignore.symbol.file'
    [javac] '--module-path'
    [javac] 'third_party/jogamp/jar'
    [javac] '--add-modules'
    [javac] 'jogl.all,gluegen.rt'
    [javac] '--add-exports'
    [javac] 'jogl.all/com.jogamp.nativewindow=jcef'
    [javac] '--add-exports'
    [javac] 'jogl.all/com.jogamp.opengl.awt=jcef'
    [javac] '--add-exports'
    [javac] 'jogl.all/com.jogamp.opengl.util=jcef'
    [javac] '--add-exports'
    [javac] 'jogl.all/com.jogamp.opengl=jcef'
    [javac] '--add-exports'
    [javac] 'java.desktop/sun.awt=jcef'
    [javac] '--add-exports'
    [javac] 'java.desktop/java.awt.peer=jcef'
    [javac] '--add-exports'
    [javac] 'java.desktop/sun.lwawt.macosx=jcef'
    [javac] '--add-exports'
    [javac] 'java.desktop/sun.lwawt=jcef'
    [javac]
    [javac] The ' characters around the executable and arguments are
    [javac] not part of the command.
    [javac] File to be compiled:
    [javac]     C:\develop\jcef_rpc_keyboard_master\java\org\cef\browser\CefBrowserWr.java
    [javac] C:\develop\jcef_rpc_keyboard_master\java\org\cef\browser\CefBrowserWr.java:436: error: cannot find symbol
    [javac]                 CefBrowserWindow browserWindow = CefBrowserWindowMac();
    [javac]                                                  ^
    [javac]   symbol:   method CefBrowserWindowMac()
    [javac]   location: class CefBrowserWr
    [javac] 1 error

Applied previous code to fix jcef build system
@DatL4g

Copy link
Copy Markdown
Author

Vladimir Kharitonov (@ujpv) seems like your build process differs from mine.

Applied previous code to fix this build system, should work now.

@ujpv

Copy link
Copy Markdown
Collaborator

Still not possible to build
How we build it on Windows
https://github.com/JetBrains/jcef#building-on-windows

Added missing InvocationTargetException import
@DatL4g

Copy link
Copy Markdown
Author

Vladimir Kharitonov (@ujpv) finding all required packages to build on Fedora was a pain, maybe add them to the README.md

However fixed now, were missing imports only.

Jeff Retz (DatL4g) and others added 11 commits October 25, 2023 22:37
break loop early (like before) if required instance is found
# Conflicts:
#	.github/ISSUE_TEMPLATE/bug_report.md
#	CMakeLists.txt
#	README.md
#	java/org/cef/CefClient.java
#	java/org/cef/handler/CefLoadHandler.java
#	java_tests/tests/junittests/TestFrame.java
#	native/CMakeLists.txt
#	native/CefBrowser_N.cpp
#	native/browser_process_handler.h
#	tools/make_docs.sh
#	tools/run.sh
@artemm-bochkarev
artemm-bochkarev force-pushed the dev branch 5 times, most recently from 416fc38 to 4628cac Compare February 25, 2024 15:06
@artemm-bochkarev
artemm-bochkarev force-pushed the dev branch 3 times, most recently from d1e1b73 to cd51a5e Compare March 4, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants