Run relevant a11y test cases for RTL layout direction - #3345
Open
janinadavydova wants to merge 1 commit into
Open
Run relevant a11y test cases for RTL layout direction#3345janinadavydova wants to merge 1 commit into
janinadavydova wants to merge 1 commit into
Conversation
janinadavydova
changed the title
| UITraitEnvironmentLayoutDirectionRightToLeft | ||
| ) | ||
|
|
||
| private fun runInBothLayoutDirections( |
There was a problem hiding this comment.
I know it's sounds too long, but let's call it runUIKitInstrumentedTestInBothLayoutDirections 😶🌫️
| } | ||
| } | ||
|
|
||
| private fun AccessibilityTestNode.linkNodesInTraversalOrder( |
There was a problem hiding this comment.
Hm... that sound interesting. Can we adjust the node() API to make it universal - like this:
node(layoutDirection = layoutDirection) {
node {}
node {}
}
And the node just adds nodes in the correct direction. WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Issues Fixed
Fixes: CMP-10665 iOS: Add RTL accessibility order smoke tests
Selected relevant a11y test cases that are worth to run for RTL and parametrised tests.
Release Notes
N/A