Add common logic for supporting UiMediaScope in Skiko platforms - #3339
Open
Apolo (ApoloApps) wants to merge 6 commits into
Open
Add common logic for supporting UiMediaScope in Skiko platforms#3339Apolo (ApoloApps) wants to merge 6 commits into
Apolo (ApoloApps) wants to merge 6 commits into
Conversation
This was referenced Aug 25, 2026
Author
| } | ||
| } | ||
|
|
||
| private object NoOpMediaEnvironment : UiMediaScope { |
There was a problem hiding this comment.
Maybe "No-Op" is the wrong name here because UiMediaScope doesn't do any "ops"; it only provides information.
Author
There was a problem hiding this comment.
renamed to EmptyMediaEnvironment
Author
|
Alexander Maryanovsky (@m-sasha) if everything is fine with this pr, I would like to get it merged asap (when y'all have time obviously). The changes in this pr need to be rebased in other PRs to avoid confusion on those |
|
It looks ok to me, but we should have another set of eyes to look first. |
Alexander Maryanovsky (m-sasha)
self-requested a review
August 26, 2026 20:33
Alexander Maryanovsky (m-sasha)
approved these changes
Aug 26, 2026
Oleksandr Karpovich (eymar)
approved these changes
Aug 27, 2026
Author
|
What a weird check error, only seems to happen in one and seems related to the android github actions?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smaller change to support UiMediaScope in skiko platforms
Fixes CMP-10481 (common part)
iOS PR: #3340
Desktop PR: #3341
Release Notes
Features - Multiple Platforms