Added support for BackgroundTextMeasurement in all Platforms - #3238
Draft
Apolo (ApoloApps) wants to merge 5 commits into
Draft
Added support for BackgroundTextMeasurement in all Platforms#3238Apolo (ApoloApps) wants to merge 5 commits into
Apolo (ApoloApps) wants to merge 5 commits into
Conversation
…ementations are provided, just a copy of the Android Api in multiplatform side)
Vladimir Mazunin (mazunin-v-jb)
requested review from
Ivan Matkov (MatkovIvan) and
Oleksandr Karpovich (eymar)
July 17, 2026 15:53
| import kotlinx.coroutines.Runnable | ||
|
|
||
| @InternalComposeUiApi | ||
| expect interface PlatformBackgroundTextMeasurementExecutor { |
There was a problem hiding this comment.
expect interface is wrong API shape/antipattern that we're trying to avoid (I know that we still have a few in the codebase)
| val density = LocalDensity.current | ||
|
|
||
| try { | ||
| val task = Runnable { |
There was a problem hiding this comment.
CMP-10613 is a blocker to run it in parallel (and merge this PR before fixing it)
Apolo (ApoloApps)
marked this pull request as draft
August 24, 2026 00:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support BackgroundTextMeasurement by adding a Platform* interface. It typealiases in JVM to Executor. This PR is a copy of the Android Api ported to Multiplatform.
I leave it up to you, CMP team, to add platform-specific implementations based in the possible performance gains it can provide. In JVM, LocalPlatformBackgroundTextMeasurementExecutor can be
Executors.newSingleThreadExecutor()(as per Android KDoc)Lays foundation for https://youtrack.jetbrains.com/issue/CMP-7818
Testing
(Optional) Describe how you tested your changes (provide a snippet or/and steps)
(Optional) This should be tested by QA
Release Notes
N/A