ShaderC dependencies and Shader Compilation Refactor#504
Merged
JeanPhilippeKernel merged 1 commit intoJeanPhilippeKernel:developfrom Mar 12, 2026
Merged
Conversation
MathewBensonCode
force-pushed
the
cmake_shader_compile
branch
from
2b1afa1 to
dc9b5be
Compare
Contributor
Author
|
I initially attempted to use the ShaderC library to reduce the compilation by trying to use the Iibraries in the ShaderC package but ran into various linking errors on the different systems. I had worked locally for me though. It was also not possible to use it with the macOS arm build as the ShaderC libraries available online are only x86-64. So I went with the option of removing the ShaderC download step and shader compilation using powershell and instead incorporate it into the CMake workflow |
JeanPhilippeKernel
added
enhancement
JeanPhilippeKernel
requested changes
Mar 11, 2026
MathewBensonCode
force-pushed
the
cmake_shader_compile
branch
from
dc9b5be to
65b5ede
Compare
- We remove the use of the shaderc download, which was only being used for compiling shaders. - We instead use the glslang compiler that we we're compiling anyway. - This way we can extract the glslang compiler that we have compiled and do the shader compilation as part of the CMake Scripting. - This should reduce the compilation times and/or storage requirements. - As Currently configured the Shaders will be compiled in each build, however, we can improve on this and ensure that compilation is only done as required at a later stage
MathewBensonCode
force-pushed
the
cmake_shader_compile
branch
from
65b5ede to
a52d8e0
Compare
JeanPhilippeKernel
approved these changes
Mar 12, 2026
Owner
JeanPhilippeKernel
left a comment
JeanPhilippeKernel
left a comment
There was a problem hiding this comment.
Thanks a lot for this awesome PR 🎉
JeanPhilippeKernel
merged commit 29d0bac
into
JeanPhilippeKernel:develop
21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should Close #481