Fix Dataset Folder input layout in sidebar#491
Open
vedcoder wants to merge 2 commits intoJdeRobot:masterfrom
Open
Fix Dataset Folder input layout in sidebar#491vedcoder wants to merge 2 commits intoJdeRobot:masterfrom
vedcoder wants to merge 2 commits intoJdeRobot:masterfrom
Conversation
Collaborator
|
Hi! First of all, thanks for your interest. Your change fixes any wrapping problems indeed, but we would like to keep the browse button right on the right side of the text box, so that it is a bit consistent with the file_uploader widgets below. Can you find a solution for the wrapping issue while keeping button and box in the same row? Thanks! |
vedcoder
added a commit
to vedcoder/PerceptionMetrics
that referenced
this pull request
Mar 31, 2026
Use column ratio [3.5, 2] to keep Browse button on the same row as the text input, consistent with file_uploader widgets. Addresses reviewer feedback on PR JdeRobot#491. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
9d0c6f1 to
3fcbb30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #490
Replaced the misaligned column layout (text_input + Browse button with hacky HTML spacer div) with a clean full-width text input and full-width Browse button, consistent with the other sidebar inputs.