Repository navigation
Handle expected leadership-lock cancellation during node shutdown - #5256
Merged
jeremydmiller merged 1 commit intoOct 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When node shutdown cancels an in-flight leadership-lock acquisition,
DoHealthChecksInternalAsynccurrently logs it as an Error. HandleOperationCanceledExceptionwhen the controller's lifetime is canceled, then return the normal empty command result. Independent cancellation while running and ordinary lock failures during shutdown retain the existing error path.Closes #5253
Validation:
TaskCanceledException; all three discriminating tests pass afterward on .NET 10 and .NET 9.dotnet build wolverine.slnx -c Release -f net9.0succeeds (one sample-project assembly-cache file contention warning).event_model_scaffold_4832; a clean detached checkout of untouched main reproduces those exact three failures (61 passed, 3 failed, no skips in that class).EventLogInternaldisposed-provider failure observed during the full suite. The focused regression logs no unexpected errors.The change does not alter shutdown ordering, lock ownership, or error severity for genuine failures.