Skip to content

fix: allow compose override - #14691

Open
iromli wants to merge 3 commits into
mainfrom
cn-aio-demo-relative
Open

fix: allow compose override#14691
iromli wants to merge 3 commits into
mainfrom
cn-aio-demo-relative

Conversation

@iromli

@iromli iromli commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Prepare


Description

Target issue

closes #14690

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Summary by CodeRabbit

  • New Features

    • Demo startup now automatically includes an optional compose.override.yaml configuration when available.
    • When no override configuration is present, startup continues using the standard Compose configuration.
  • Documentation

    • Updated uninstall instructions to remove the optional override configuration along with other Docker Compose resources.

Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli self-assigned this Aug 3, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0e98dc59-7835-4899-8577-bef951aba265

📥 Commits

Reviewing files that changed from the base of the PR and between 3e761dc and 8216a27.

📒 Files selected for processing (1)
  • docs/janssen-server/install/docker-install/quick-start.md

📝 Walkthrough

Walkthrough

The AIO demo startup now loads compose.override.yaml when present. The quick-start uninstall command uses Docker Compose’s default configuration and removes the override file.

Changes

AIO demo Compose execution

Layer / File(s) Summary
Compose startup and uninstall cleanup
automation/start_janssen_aio_demo.sh, docs/janssen-server/install/docker-install/quick-start.md
The script includes compose.override.yaml when it exists. The uninstall instructions stop the default Compose configuration and remove the override file.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: area-documentation, comp-docs

Suggested reviewers: misba7, moabu

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Compose override fix implemented in the startup script.
Description check ✅ Passed The description includes preparation, the target issue, testing status, and documentation impact, but leaves implementation details and some checklist items incomplete.
Linked Issues check ✅ Passed The PR updates the startup script to load compose.override.yaml, satisfying the requirement in issue #14690.
Out of Scope Changes check ✅ Passed All changes support Compose override handling, including the related uninstall documentation update, so no unrelated scope is evident.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cn-aio-demo-relative

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mo-auto

mo-auto commented Aug 3, 2026

Copy link
Copy Markdown
Member

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@mo-auto mo-auto added area-CI Issue or changes required in automatic builds or CI infrastructure kind-bug Issue or PR is a bug in existing functionality labels Aug 3, 2026
@iromli
iromli requested a review from misba7 August 3, 2026 17:57
@iromli
iromli marked this pull request as ready for review August 3, 2026 17:57
@iromli
iromli requested a review from moabu as a code owner August 3, 2026 17:57

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@automation/start_janssen_aio_demo.sh`:
- Line 5: Update the demo generation path in the startup script to use
automation/jans-aio-demo, and execute Docker Compose from the automation
directory with automation/compose.yaml so generated files, TLS permissions, and
the Compose project remain aligned with the CI contract.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 482fe148-1543-4206-98a6-d7bd71088fdc

📥 Commits

Reviewing files that changed from the base of the PR and between c7706bf and a1cb6f0.

📒 Files selected for processing (1)
  • automation/start_janssen_aio_demo.sh

Comment thread automation/start_janssen_aio_demo.sh Outdated
@iromli iromli changed the title fix: allow compose override using relative path fix: allow compose override Aug 3, 2026
Signed-off-by: iromli <isman.firmansyah@gmail.com>
coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 3, 2026
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@coderabbitai coderabbitai Bot added area-documentation Documentation needs to change as part of issue or PR comp-docs Touching folder /docs labels Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-CI Issue or changes required in automatic builds or CI infrastructure area-documentation Documentation needs to change as part of issue or PR comp-docs Touching folder /docs kind-bug Issue or PR is a bug in existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: allow compose override

2 participants