Rename CustomSampler to PresetSampler and add preset dataloader test#1637
Merged
HAOCHENYE merged 25 commits intoInternLM:mainfrom Mar 31, 2026
Merged
Rename CustomSampler to PresetSampler and add preset dataloader test#1637HAOCHENYE merged 25 commits intoInternLM:mainfrom
HAOCHENYE merged 25 commits intoInternLM:mainfrom
Conversation
jayhenry
force-pushed
the
preset_sampler
branch
from
9065369 to
ff3db03
Compare
- Modified the `_load_sampler_config` function to enforce the use of `.npy` files and validate the loaded array's properties. - Changed the behavior of the sampler to truncate the global order length to the nearest multiple of `global_batch_size * world_size` instead of rounding up.
jayhenry
force-pushed
the
preset_sampler
branch
from
c6171da to
fccd39f
Compare
HAOCHENYE
approved these changes
Mar 31, 2026
HAOCHENYE
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.