Make tilelang a Linux-only dependency (like triton)#4469
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CUDA runtime dependencies so tilelang is only installed on supported platforms (Linux, non-ARM), matching the existing triton platform marker behavior and preventing install/build failures on Windows and ARM.
Changes:
- Add a Linux/non-ARM PEP 508 environment marker to the
tilelangdependency inrequirements/runtime_cuda.txt.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: lvhan028 <4560679+lvhan028@users.noreply.github.com> Agent-Logs-Url: https://github.com/InternLM/lmdeploy/sessions/ec1d8f1b-99d2-49a0-b287-82169e4fed7a
836cf4f to
2b950a4
Compare
windreamer
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
tilelangwas added as an unconditional dependency in 0.12.2, but it is painful to build on Windows and requires a C++ compiler at runtime. It is only used by CUDA-specific SSM kernels (GatedDeltaRule, causal_conv1d) which are irrelevant on non-Linux platforms.Modification
Add the same platform marker to
tilelanginrequirements/runtime_cuda.txtthat already governstriton:The Python call-sites already gate on
has_tilelang(), so no runtime behaviour changes on Linux.BC-breaking (Optional)
No. Windows and ARM Linux users were already unable to use
tilelang-backed kernels; this just stops the install from failing.Use cases (Optional)
N/A
Checklist