fix(apigw): register HttpMethod in logging serialization context#75
Open
Im5tu wants to merge 1 commit into
Open
fix(apigw): register HttpMethod in logging serialization context#75Im5tu wants to merge 1 commit into
Im5tu wants to merge 1 commit into
Conversation
Microsoft.Extensions.Http logs the HttpRequestMessage method when an outbound HttpClient request starts. The value reaches the JSON logger as a boxed HttpMethod, and DictionaryJsonConverter threw because the ApiGateway LoggingSerializationContext had no type info for it, causing 'An error occurred while writing to logger(s)'. Register HttpMethod, mirroring the Core logging context.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR extends the logging serialization context to support JSON serialization of ChangesHttpMethod Serialization Support
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Microsoft.Extensions.Httplogs the request method when an outboundHttpClientrequest starts ("Start processing HTTP request {HttpMethod} {Uri}"). The boxedHttpMethodreached the JSON logger andDictionaryJsonConverterthrew because the ApiGatewayLoggingSerializationContexthad no type info for it, producing recurring errors:This registers
HttpMethodin the ApiGateway context, mirroring the Core logging context.Notes
"httpMethod": { "method": "GET" }(object form).Uri,HttpStatusCode,TimeSpan, …). A gracefulToString()fallback inDictionaryJsonConverterwould close that whole class — out of scope here by request.Testing
dotnet buildonGoa.Functions.ApiGateway— 0 errors, 0 warnings.🤖 Generated with Claude Code