frequency-conversion in macro-data initialization#85
Open
agurgone wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on PR #83.
This PR fixes several frequency-conversion issues in macro-data initialization. The main problem was that some data sources were implicitly treated as quarterly even when the model was configured with a different
time_unit. This could produce incorrectly scaled household cash flows, exogenous series, firm flows, and initial loan values.Issue
The model configuration defines the number of model periods per year through
time_unit, but several initialization paths still used hard-coded quarterly assumptions.Examples included:
These issues can materially distort initialization, especially when using a non-quarterly
time_unit.Changes
yearly_factor = 12 / time_unitplumbing through macro-data readers and synthetic population initialization.time_unit.BankParametersinstead of duplicating hard-coded values.Notes
The FRA data config still stores loan maturities in model periods. This PR does not convert config values from months at runtime; instead, it makes the expectation explicit and aligns defaults with the model configuration.
Validation
Ran targeted validation before committing:
ruff checkon touched Python filesgit diff --checktests/test_macro_data/unit/test_data_wrapper.pyResult: targeted tests passed.