Add markup-based bank interest-rate pricing#84
Open
agurgone wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency
Blocked by #83
This PR contains commits from #83 and should be reviewed after that merges.
Issue
The existing bank-rate setup could produce borrowing rates below the policy rate. It also did not provide a clean way to switch between the current ECT behaviour and a simple policy-plus-spread rule.
Changes
add MarkUpInterestRatesSetter while keeping DefaultInterestRatesSetter unchanged
calibrate mean pre-start spreads from quarterly product-rate minus policy-rate data
store those spreads on synthetic banks and pass them into bank state
price loans under the markup rule as max(policy_rate + spread, 0)
keep deposit-side rates at policy in the markup regime
allow selecting MarkUpInterestRatesSetter in bank config
support optional runtime spread overrides via setter parameters
add/update tests for spread calibration and markup pricing
Notes
both firm short and firm long spreads currently use the same calibrated firm spread
existing ECT behaviour is unchanged
ECT behaviour
Mark-up behaviour
