Skip to content

added agent.MasonScheduledAgent.java#1

Open
x0range wants to merge 3 commits into
INET-Complexity:masterfrom
x0range:newFeatureMasonScheduledAgent
Open

added agent.MasonScheduledAgent.java#1
x0range wants to merge 3 commits into
INET-Complexity:masterfrom
x0range:newFeatureMasonScheduledAgent

Conversation

@x0range

@x0range x0range commented Feb 1, 2017

Copy link
Copy Markdown

Hi Paul,

this includes the MasonScheduledAgent class as discussed.

Best wishes

@DavoudTaghawiNejad

Copy link
Copy Markdown
Contributor

Please rename findNextEvent to scheduleNextEvent, so it is clear what this function does when reading it from the perspective of the agent.

@DavoudTaghawiNejad

Copy link
Copy Markdown
Contributor

Hi,
I integrated this change into the refactored and maven compatible version. This can therefore be closed.

@x0range

x0range commented Feb 27, 2017

Copy link
Copy Markdown
Author

Hi,
I added comments consistent with those in other Core ESL modules last week which are not included in your last maven compatible pull request commit. Also, one method is named scheduleNextEvent but should be named getNextEventTime.

@DavoudTaghawiNejad

Copy link
Copy Markdown
Contributor

OK, I will merge it in then.

@DavoudTaghawiNejad

Copy link
Copy Markdown
Contributor

Hi,

as I changed the package structure. MasonScheduledAgent is called now SimpleScheduledAgent. In order to facilitate the merge, could you please rename the agent. If you want a different name, rename the agent to SimpleScheduledAgent, and once the branch is merged in you can rename the agent again.

Davoud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants