Skip to content

replace string concat with path.join #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gowin20 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

replace string concat with path.join #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Directory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export class Directory {

public async read(): Promise<void> {
// canvases are directories starting with an underscore
const canvasesPattern: string = this.directoryFilePath + "/_*";
const canvasesPattern: string = join(this.directoryFilePath, "/_*");

const canvases: string[] = await glob(canvasesPattern, {
ignore: ["**/*.yml", "**/thumb.*", "**/!*"],
Expand All @@ -74,7 +74,7 @@ export class Directory {

// directories not starting with an underscore
// these can be child manifests or child collections
const directoriesPattern: string = this.directoryFilePath + "/*";
const directoriesPattern: string = join(this.directoryFilePath, "/*");

const directories: string[] = await glob(directoriesPattern, {
ignore: [
Expand Down Expand Up @@ -120,7 +120,7 @@ export class Directory {
// create a canvas for each.
if (!this.directories.length && !canvases.length) {
const paintableFiles: string[] = await glob(
this.directoryFilePath + "/*.*",
join(this.directoryFilePath, "/*.*"),
{
ignore: ["**/*.yml", "**/thumb.*", "**/index.json"],
}
Expand Down