Replace deprecated pkg_resources usage in mongo observer#943
Draft
pulkitgoyal56 wants to merge 5 commits into
Draft
Replace deprecated pkg_resources usage in mongo observer#943pulkitgoyal56 wants to merge 5 commits into
pulkitgoyal56 wants to merge 5 commits into
Conversation
Collaborator
|
Hi @pulkitgoyal56! Thanks for addressing this issue! It seems like your modification is not backward-compatible, can you fix it for Python <=3.9? Also, we use black formatting, please run the pre-commit hook. It will fix the |
Author
|
Hey, thanks for your reply. I'll fix it and apply the formatting. |
Author
|
I'd like to finish this issue, but keeping support for Python <= 3.9 is just hacky. Given that they have reached EOL, maybe this is not really required? But if you still want to keep support for it, I'll cancel this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prefer stdlib
importlib.resourcesto locatesacred/data/mime.typesand fall back topkg_resourcesonly if necessary. This avoidsUserWarningaboutpkg_resourcesdeprecation when importingsacred.observers.mongo.This adds support for Python 3.13/14.
Rationale
pkg_resourcesis deprecated as an API;importlib.resourcesis the modern replacement in the stdlib and available in most supported Python versions.This change is backwards-compatible and preserves previous behavior by falling back to
pkg_resourceswhenimportlib.resources is not available.Files Changed
sacred/observers/mongo.pyTesting
Smoke-tested import and mime detection locally.
Follow-up
Consider removing other uses of pkg_resources (e.g., sacred/dependencies.py).