fixes: Random fixes / improvements#239
Merged
Merged
Conversation
Bound the check against the padded (ceil) symbol count so the out-of-bounds case is rejected with -EINVAL. Not reachable at current field sizes, but the check was incorrect and fragile against future size changes. Signed-off-by: Flavio Ceolin <flavio@hubble.com>
github-actions
Bot
requested review from
HongNguyen635,
buckleypaul and
hunterhubble
Seed the C library PRNG the first time hubble_rand_get() is called so the random sequence is not identical across boots. Signed-off-by: Flavio Ceolin <flavio@hubble.com>
HongNguyen635
approved these changes
Jun 11, 2026
HongNguyen635
left a comment
HongNguyen635
left a comment
Collaborator
There was a problem hiding this comment.
Probably another PR but while re-reading the hubble_bitarray, I don't think I saw the len field being used anywhere. Is this a remnant from an old design? If so, is it safe to remove then?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_encode. Although it is not a problem right now because of the size of buffers we use, the algorithm itself has an issue and may cause a problem in future.