refactor: extract shared pagination helper from duplicated boilerplate#434
Open
va932555-art wants to merge 1 commit into
Open
refactor: extract shared pagination helper from duplicated boilerplate#434va932555-art wants to merge 1 commit into
va932555-art wants to merge 1 commit into
Conversation
|
@va932555-art Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the duplicated "clamp limit, skip start, break at count" pagination loop into a shared generic
paginate()function in a newpagination.rsmodule.Changes
dongle-smartcontract/src/pagination.rs— genericpaginate<T: Clone>(env, items, start, limit) -> Vec<T>withMAX_PAGE_LIMIT = 100lib.rs— addedpub mod pagination;featured_registry.rs—list_featured_projectsnow callspaginate()on IDs, then looks up projectscollection_registry.rs— bothlist_collectionsandlist_collection_projectsnow callpaginate()What was removed
~30 lines of identical pagination boilerplate across 3 functions, replaced with 3 one-line
paginate()calls.Fixes #336