docs: reconcile CONTRACT_INTERFACE.md with lib.rs public API#429
Merged
Naomi-Gift merged 1 commit intoJul 27, 2026
Merged
Conversation
- Added missing admin proposal/threshold functions: get_admin_approval_threshold, set_admin_approval_threshold, create_proposal, approve_proposal, execute_proposal, get_proposal - Added project registry functions: update_security_contact, submit_security_contact_proof, get_security_contact_status, set_project_region, get_project_region, get_project_integrity_hash, list_projects_sorted, claim_contract_address, approve_contract_claim, reject_contract_claim, get_verified_contracts, add_maintainer, remove_maintainer, get_maintainers - Added reserved name functions: add_reserved_name, remove_reserved_name, get_reserved_names, is_name_reserved - Added review registry functions: get_weighted_rating, get_review_revision_count, get_review_history, get_review_tombstone, list_reviews_sorted - Added verification functions: update_verification_evidence, get_verification_record, clear_verification_history, clear_renewal_history, assign_verification, get_assigned_admin - Added fee manager functions: is_fee_paid, pay_registration_fee, get_fee_payment_details, get_reg_fee_payment_details - Added new sections: Subscription/Follow, Bookmarks, Endorsements, Admin Timelock - Updated error codes table to match actual ContractError enum in errors.rs - Updated Table of Contents and last-updated date closes HubDApp#376
|
@young-wallace Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reconciles
CONTRACT_INTERFACE.mdagainst the actuallib.rspublic API. 120+ functions were missing or the documentation was out of date. All 168 public functions exposed by#[contractimpl] impl DongleContractare now documented.Changes Made
Added Missing Admin Functions
get_admin_approval_threshold,set_admin_approval_thresholdcreate_proposal,approve_proposal,execute_proposal,get_proposalAdded Missing Project Registry Functions
update_security_contact,submit_security_contact_proof,get_security_contact_statusset_project_region,get_project_region,get_project_integrity_hashlist_projects_sortedfor sort-mode project listingclaim_contract_address,approve_contract_claim,reject_contract_claim,get_verified_contractsadd_maintainer,remove_maintainer,get_maintainersadd_reserved_name,remove_reserved_name,get_reserved_names,is_name_reservedAdded Missing Review Registry Functions
get_weighted_rating,get_review_revision_count,get_review_historyget_review_tombstone,list_reviews_sortedAdded Missing Verification Functions
update_verification_evidence,get_verification_recordclear_verification_history,clear_renewal_historyassign_verification,get_assigned_adminAdded Missing Fee Manager Functions
is_fee_paid,pay_registration_feeget_fee_payment_details,get_reg_fee_payment_detailsAdded Entirely New Sections
follow_project,unfollow_project,get_follower_count,is_following,get_project_followers,get_user_subscriptionsbookmark_project,unbookmark_project,is_bookmarked,get_user_bookmarksendorse_project,unendorse_project,get_endorsement_count,has_endorsedschedule_set_fee,schedule_add_admin,schedule_remove_admin,cancel_scheduled_action,execute_scheduled_set_fee,execute_scheduled_add_admin,execute_scheduled_remove_admin,get_scheduled_action,list_scheduled_actions,get_scheduled_action_countError Codes Table
ContractErrorenum inerrors.rsOther Updates
closes #376